Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update npm comment in Docker example #33881

Merged
merged 1 commit into from
Feb 1, 2022
Merged

Update npm comment in Docker example #33881

merged 1 commit into from
Feb 1, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Feb 1, 2022

Fixes: #33783
x-ref: #33695 (comment)

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added examples Issue/PR related to examples created-by: Next.js team PRs by the Next.js team. labels Feb 1, 2022
@ijjk ijjk requested a review from styfle February 1, 2022 22:02
@ijjk ijjk merged commit d005631 into vercel:canary Feb 1, 2022
@ijjk ijjk deleted the example/dockerfile-npm branch February 1, 2022 22:52
natew pushed a commit to natew/next.js that referenced this pull request Feb 16, 2022
@ijjk @natew
Update npm comment in Docker example (vercel#33881)
f9dda2d
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@styfle styfle styfle approved these changes

@leerob leerob Awaiting requested review from leerob

@shuding shuding Awaiting requested review from shuding

@steven-tey steven-tey Awaiting requested review from steven-tey

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team. examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect directory for npm case
2 participants
@ijjk @styfle